Android Java files support Cordova 1.9+, also BlackBerry support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does 558e2a6 affect Android Cordova > 1.9? |
|
So it does not directly translate into an Activity / Context. It can, in most cases it does, but it is not necessary. Think of the case where Cordova is embedded inside a larger native application. No guarantee that the "housing" class is an instance of Activity or Context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlackBerry support will be dependent on BlackBerry support landing in pluginstall.
For the Android Java updates, pretty sure this would eliminate support for Cordova before 1.9. Fair warning.
Also consolidated the .js between Android and BlackBerry. No longer require a separate API there.
Finally: put all of the image assets into the common
www/childbrowser/folder. Figured it was not worth keeping separate assets for BlackBerry and Android.